Fix sync errors when trying to delete video component of live photos #7435
Conversation
|
/backport to stable-3.14 |
|
@claucambra When copying a folder containing "Live Photos" to a different location, what happens to the |
From the client perspective, we propagate the copy to the server and then pull down whatever state these files are in post copy remotely. We don't manually mark these new files as live photos (at least, not at the moment) |
I have just tested 3.14.3 on Mac OS and the sync client does not use That's why I am a little in doubt if the content's |
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
… directory job Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
…other types of items Signed-off-by: Claudio Cambra <[email protected]>
…wnload this Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
mgallien
force-pushed
the
bugfix/live-photos-delete
branch
from
263cc13 to
3b5222d
Compare
|
AppImage file: nextcloud-PR-7435-3b5222d457d43845039c0d942a9ff0895399ecc6-x86_64.AppImage |
|
Live photos uploaded to the server are composed of an image file (usually a .jpeg or a .heic) and a video file (a .mov file), which get presented to the user via the iOS and Web UIs as a single "live photo", like in the Apple Photos applications
To maintain this representation the server treats these image/video pairs as inseparable -- the video cannot be deleted by itself, only a delete of the image will lead to the deletion of the video. This means we cannot issue deletes for the videos, as the server will reject this and we will end up showered in sync errors.
This PR therefore changes the local discovery behaviour to not propagate the local deletion of live photo mov files to the server, and to instead simply re-download the file if it has been deleted